Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates msw to v2. (PP-1261) #112

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented May 24, 2024

Description

  • Upgrades msw from v1 to v2.
  • Polyfills some objects in the jest environment to support the change.
  • Corrects a handler that was not working as intended, even before the upgrade.

Motivation and Context

We will be adding more tests that rely on msw, so it made sense to upgrade now, rather than having many more tests to upgrade in the not-too-distant future.

[Jira PP-1261]

How Has This Been Tested?

  • All tests pass locally.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee May 24, 2024 02:14
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tdilauro tdilauro merged commit 268e02e into main May 24, 2024
@tdilauro tdilauro deleted the task/upgrade-msw-to-something-newer branch May 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants