Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move book editor state to redux toolkit slices model. (PP-1350) #119

Merged
merged 18 commits into from
Jun 28, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Jun 26, 2024

Description

Convert book editor state to Redux Toolkit slices model.

Motivation and Context

  • Separate out some logic to make it easier to handle PP-985 and future work.
  • Move toward Redux current best practice.

[Jira PP-1350]

How Has This Been Tested?

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee June 26, 2024 17:44
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

});
afterAll(() => fetchMock.restore());

it("should return the book data on the happy path", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I be on the happy path? 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question from me! 😅

@tdilauro tdilauro merged commit 6accec3 into main Jun 28, 2024
1 check passed
@tdilauro tdilauro deleted the chore/book-editor-to-redux-slices branch June 28, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants