Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide inventory report text when button hidden. (PP-1649) #129

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Hide inventory report text when button hidden. (PP-1649) #129

merged 1 commit into from
Aug 27, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Aug 26, 2024 •
edited by jira bot
Loading

Description

  • Hides the inventory request description text when the request button is hidden.
  • Add verification tests to the test suite.

Motivation and Context

Having an explanation for a control that is not visible is confusing.

[Jira PP-1649]

How Has This Been Tested?

  • Manually tested locally.
  • Tests pass locally.
  • CI tests pass for associated branch.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team August 26, 2024 20:42
ray-lee
ray-lee approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tdilauro tdilauro merged commit f853860 into main Aug 27, 2024
1 check passed
@tdilauro tdilauro deleted the bugfix/hide-inventory-report-blurb-with-button branch August 27, 2024 12:00
@tdilauro tdilauro added the bug Something isn't working label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-lee ray-lee ray-lee approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @ray-lee