Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Redux DevTools browser extension to be used. #13

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

ray-lee
Copy link
Contributor

@ray-lee ray-lee commented Oct 14, 2021

Description

This allows the Redux DevTools browser extension to be used on the app.

Motivation and Context

This is very helpful for debugging, allowing state changes in the app to be easily inspected.

How Has This Been Tested?

  1. Install the Redux DevTools browser extension in Chrome or Firefox.
  2. Run the circulation-admin app.
  3. Open the Redux tab in the browser's dev tools, and see that actions are logged as the app is used.

Also ensure that the app continues to run correctly in browsers that do not have the Redux DevTools extension installed.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@ray-lee ray-lee requested a review from tdilauro October 14, 2021 21:52
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

This doesn't seem have much impact on performance, so I don't think it needs to be scoped to development.

@ray-lee ray-lee merged commit a828d1f into main Oct 15, 2021
@ray-lee ray-lee deleted the allow-redux-devtools branch October 15, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants