Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag for to restrict QuickSight link to sysadmins. (PP-1724) #135

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add feature flag for to restrict QuickSight link to sysadmins. (PP-1724) #135

merged 1 commit into from
Sep 18, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Sep 18, 2024 •
edited by jira bot
Loading

Description

  • Adds a feature flag to hide the dashboard statistics link to the QuickSight page from non-sysadmin users.
  • Adds business logic and rendering tests for the new functionality.

Motivation and Context

Need to be able to hide QuickSight dashboard until it is ready to launch.

[Jira PP-1724]

How Has This Been Tested?

  • Manual testing locally.
  • All tests pass locally.
  • CI tests pass.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

jonathangreen
jonathangreen approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always with front-end PRs, my knowledge limited, but this all looks good to me.

@tdilauro tdilauro merged commit 2ddcc4f into main Sep 18, 2024
1 check passed
@tdilauro tdilauro deleted the feature/feature-flag-quicksight-for-sysadmins-only branch September 18, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathangreen jonathangreen jonathangreen approved these changes

@ray-lee ray-lee Awaiting requested review from ray-lee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @jonathangreen