Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freeze_time decorator to test_compressible #1996

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jonathangreen
Copy link
Member

Description

I've seen the test_compressible test fail occasionally. Its always one byte off, and I think its because there is a timestamp that is getting compressed, and occasionally we cross a second boundary causing this test to fail.

Add the freeze_time decorator so that we don't have to worry about time in this test.

Motivation and Context

This test is failing right now in main: https://github.com/ThePalaceProject/circulation/actions/runs/10473254405/job/29004736627

How Has This Been Tested?

  • Running tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team August 20, 2024 15:15
@jonathangreen jonathangreen added the bug Something isn't working label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (eb2dc69) to head (d6859b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
- Coverage   90.63%   90.63%   -0.01%     
==========================================
  Files         339      339              
  Lines       40210    40210              
  Branches     8702     8702              
==========================================
- Hits        36444    36443       -1     
- Misses       2493     2494       +1     
  Partials     1273     1273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@jonathangreen jonathangreen merged commit 4c35cd7 into main Aug 20, 2024
20 checks passed
@jonathangreen jonathangreen deleted the chore/fix-flakey-compressible-test branch August 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants