Allow restriction to multiple patron locations. (PP-1648) #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
+ Coverage 90.70% 90.79% +0.08%
==========================================
Files 343 344 +1
Lines 40584 40610 +26
Branches 6588 8793 +2205
==========================================
+ Hits 36813 36872 +59
+ Misses 2501 2484 -17
+ Partials 1270 1254 -16 ☔ View full report in Codecov by Sentry. |
tdilauro
force-pushed
the
feature/multi-location-restriction
branch
from
e66a7f1
to
dbc19e7
Compare
|
@jonathangreen This could use another look when you have a moment. I'm doing some more manual testing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support more than a single patron location when restricting which patrons can be associated with a given library.
This PR does this by adding an additional Library Identifier Field, "Patron Location", to the fields that can be used to restrict library membership.
Note:
Setting this PR as draft for now, since I still need to remove the recently added single-valued patron location restriction and add/update some more tests, but would be happy to get an initial review on the approach here.
Motivation and Context
Some libraries have multiple locations, so we need a mechanism to support those.
[Jira PP-1648]
How Has This Been Tested?
Checklist