Don't cache overdrive token in credentials table (PP-1717) #2060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't cache the overdrive authentication token in the credentials table. Instead just refresh it when we need it. This prevents multiple threads / processes from getting into a deadlock waiting on postgres transactions that are all trying to update the same credential object.
Motivation and Context
Debugging the deadlock in PP-1717, and this is a factor in that deadlock. It may not be the only issue, but its one of the factors causing this deadlock.
This will mean calling out to get a session token slightly more often, but it shouldn't matter doing one extra call to their API now and then. If we were really concerned we could cache these in redis, but it doesn't seem worth the effort.
How Has This Been Tested?
Checklist