Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from 3b1b:master #16

Merged
merged 8 commits into from
Jan 3, 2023
Merged

[pull] master from 3b1b:master #16

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cec43df
Use Vect3 type in fading.py
3b1b Dec 30, 2022
96bc95e
Allow FadeTransform to group parts as VGroup if applicable
3b1b Dec 30, 2022
4335e85
Abstract away logic of TransformMatchingStrings to a new version of T…
3b1b Dec 30, 2022
3aa9eb6
Add String.get_symbol_substrings and Tex.get_symbol_substrings
3b1b Dec 30, 2022
4c1f1f8
Clean up TransformMatchingStrings
3b1b Dec 30, 2022
a31c4ae
Add more indexing details to TexTransformExample
3b1b Dec 30, 2022
abf1dd3
Typo fix
3b1b Jan 2, 2023
bf5d587
Merge pull request #1957 from 3b1b/video-work
3b1b Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use Vect3 type in fading.py
  • Loading branch information
@3b1b
3b1b committed Dec 30, 2022
commit cec43dfe51fc4aff41a6cf848b4b270946310a28
7 changes: 4 additions & 3 deletions manimlib/animation/fading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from manimlib.mobject.mobject import Mobject
from manimlib.mobject.types.vectorized_mobject import VMobject
from manimlib.scene.scene import Scene
from manimlib.typing import Vect3



Expand Down Expand Up @@ -48,7 +49,7 @@ class FadeOut(Fade):
def __init__(
self,
mobject: Mobject,
shift: np.ndarray = ORIGIN,
shift: Vect3 = ORIGIN,
remover: bool = True,
final_alpha_value: float = 0.0, # Put it back in original state when done,
**kwargs
Expand All @@ -69,7 +70,7 @@ def create_target(self) -> Mobject:


class FadeInFromPoint(FadeIn):
def __init__(self, mobject: Mobject, point: np.ndarray[int, np.dtype[np.float64]], **kwargs):
def __init__(self, mobject: Mobject, point: Vect3, **kwargs):
super().__init__(
mobject,
shift=mobject.get_center() - point,
Expand All @@ -79,7 +80,7 @@ def __init__(self, mobject: Mobject, point: np.ndarray[int, np.dtype[np.float64]


class FadeOutToPoint(FadeOut):
def __init__(self, mobject: Mobject, point: np.ndarray[int, np.dtype[np.float64]], **kwargs):
def __init__(self, mobject: Mobject, point: Vect3, **kwargs):
super().__init__(
mobject,
shift=point - mobject.get_center(),
Expand Down