MDL-51015 mod_scorm: tidy up messy code, remove use of eval()

TheVirtualLtd · Aug 6, 2015 · 524aaa1 · 524aaa1
1 parent 57739a7
commit 524aaa1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/mod/scorm/locallib.php b/mod/scorm/locallib.php
@@ -1303,7 +1303,7 @@ function scorm_get_attempt_count($userid, $scorm, $returnobjects = false, $ignor
  * @return boolean - debugging true/false
  */
 function scorm_debugging($scorm) {
-    global $CFG, $USER;
+    global $USER;
     $cfgscorm = get_config('scorm');
 
     if (!$cfgscorm->allowapidebug) {
@@ -1315,9 +1315,11 @@ function scorm_debugging($scorm) {
     if (!preg_match('/^[\w\s\*\.\?\+\:\_\\\]+$/', $test)) {
         return false;
     }
-    $res = false;
-    eval('$res = preg_match(\'/^'.$test.'/\', $identifier) ? true : false;');
-    return $res;
+
+    if (preg_match('/^'.$test.'/', $identifier)) {
+        return true;
+    }
+    return false;
 }
 
 /**