MDL-35904 send notifications from main admin and improve coding style

TheVirtualLtd · Oct 13, 2012 · 5507901 · 5507901
1 parent 3ed5751
commit 5507901
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 20 deletions.
diff --git a/admin/cli/upgrade.php b/admin/cli/upgrade.php
@@ -159,9 +159,7 @@
 upgrade_noncore(true);
 
 // log in as admin - we need doanything permission when applying defaults
-$admins = get_admins();
-$admin = reset($admins);
-session_set_user($admin);
+session_set_user(get_admin());
 
 // apply all default settings, just in case do it twice to fill all defaults
 admin_apply_default_settings(NULL, false);

diff --git a/admin/handlevirus.php b/admin/handlevirus.php
@@ -86,7 +86,7 @@ function notify_admins($user,$subject,$a) {
     foreach ($admins as $admin) {
         $eventdata = new stdClass();
         $eventdata->modulename        = 'moodle';
-        $eventdata->userfrom          = $admin;
+        $eventdata->userfrom          = get_admin();
         $eventdata->userto            = $admin;
         $eventdata->subject           = $subject;
         $eventdata->fullmessage       = $body;
@@ -107,7 +107,7 @@ function notify_admins_unknown($file,$a) {
     foreach ($admins as $admin) {
         $eventdata = new stdClass();
         $eventdata->modulename        = 'moodle';
-        $eventdata->userfrom          = $admin;
+        $eventdata->userfrom          = get_admin();
         $eventdata->userto            = $admin;
         $eventdata->subject           = $subject;
         $eventdata->fullmessage       = $body;

diff --git a/lib/installlib.php b/lib/installlib.php
@@ -476,9 +476,7 @@ function install_cli_database(array $options, $interactive) {
     upgrade_finished();
 
     // log in as admin - we need do anything when applying defaults
-    $admins = get_admins();
-    $admin = reset($admins);
-    session_set_user($admin);
+    session_set_user(get_admin());
 
     // apply all default settings, do it twice to fill all defaults - some settings depend on other setting
     admin_apply_default_settings(NULL, true);

diff --git a/lib/pluginlib.php b/lib/pluginlib.php
@@ -1315,13 +1315,11 @@ protected function cron_notify(array $notifications) {
         $html .= html_writer::tag('footer', html_writer::tag('p', get_string('updatenotificationfooter', 'core_admin', $a),
             array('style' => 'font-size:smaller; color:#333;')));
 
-        $mainadmin = reset($admins);
-
         foreach ($admins as $admin) {
             $message = new stdClass();
             $message->component         = 'moodle';
             $message->name              = 'availableupdate';
-            $message->userfrom          = $mainadmin;
+            $message->userfrom          = get_admin();
             $message->userto            = $admin;
             $message->subject           = get_string('updatenotifications', 'core_admin');
             $message->fullmessage       = $text;

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
@@ -1120,7 +1120,7 @@ function portfolio_insane_notify_admins($insane, $instances=false) {
         $eventdata->modulename = 'portfolio';
         $eventdata->component = 'portfolio';
         $eventdata->name = 'notices';
-        $eventdata->userfrom = $admin;
+        $eventdata->userfrom = get_admin();
         $eventdata->userto = $admin;
         $eventdata->subject = $subject;
         $eventdata->fullmessage = $plainbody;

diff --git a/portfolio/googledocs/db/upgrade.php b/portfolio/googledocs/db/upgrade.php
@@ -52,15 +52,14 @@ function portfolio_googledocs_admin_upgrade_notification() {
     if (empty($admins)) {
         return;
     }
-    $mainadmin = reset($admins);
     $a = new stdClass;
     $a->docsurl = get_docs_url('Google_OAuth_2.0_setup');
 
     foreach ($admins as $admin) {
         $message = new stdClass();
         $message->component         = 'moodle';
         $message->name              = 'notices';
-        $message->userfrom          = $mainadmin;
+        $message->userfrom          = get_admin();
         $message->userto            = $admin;
         $message->smallmessage      = get_string('oauth2upgrade_message_small', 'portfolio_googledocs');
         $message->subject           = get_string('oauth2upgrade_message_subject', 'portfolio_googledocs');

diff --git a/portfolio/picasa/db/upgrade.php b/portfolio/picasa/db/upgrade.php
@@ -52,15 +52,14 @@ function portfolio_picasa_admin_upgrade_notification() {
     if (empty($admins)) {
         return;
     }
-    $mainadmin = reset($admins);
     $a = new stdClass;
     $a->docsurl = get_docs_url('Google_OAuth_2.0_setup');
 
     foreach ($admins as $admin) {
         $message = new stdClass();
         $message->component         = 'moodle';
         $message->name              = 'notices';
-        $message->userfrom          = $mainadmin;
+        $message->userfrom          = get_admin();
         $message->userto            = $admin;
         $message->smallmessage      = get_string('oauth2upgrade_message_small', 'portfolio_picasa');
         $message->subject           = get_string('oauth2upgrade_message_subject', 'portfolio_picasa');

diff --git a/repository/googledocs/db/upgrade.php b/repository/googledocs/db/upgrade.php
@@ -55,15 +55,14 @@ function repository_googledocs_admin_upgrade_notification() {
     if (empty($admins)) {
         return;
     }
-    $mainadmin = reset($admins);
 
     $a = new stdClass;
     $a->docsurl = get_docs_url('Google_OAuth_2.0_setup');
     foreach ($admins as $admin) {
         $message = new stdClass();
         $message->component         = 'moodle';
         $message->name              = 'notices';
-        $message->userfrom          = $mainadmin;
+        $message->userfrom          = get_admin();
         $message->userto            = $admin;
         $message->smallmessage      = get_string('oauth2upgrade_message_small', 'repository_googledocs');
         $message->subject           = get_string('oauth2upgrade_message_subject', 'repository_googledocs');

diff --git a/repository/picasa/db/upgrade.php b/repository/picasa/db/upgrade.php
@@ -55,15 +55,14 @@ function repository_picasa_admin_upgrade_notification() {
     if (empty($admins)) {
         return;
     }
-    $mainadmin = reset($admins);
     $a = new stdClass;
     $a->docsurl = get_docs_url('Google_OAuth_2.0_setup');
 
     foreach ($admins as $admin) {
         $message = new stdClass();
         $message->component         = 'moodle';
         $message->name              = 'notices';
-        $message->userfrom          = $mainadmin;
+        $message->userfrom          = get_admin();
         $message->userto            = $admin;
         $message->smallmessage      = get_string('oauth2upgrade_message_small', 'repository_picasa');
         $message->subject           = get_string('oauth2upgrade_message_subject', 'repository_picasa');