Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify scheme of ServiceProviderConfiguration #1154

Conversation

DavidLievrouw
Copy link

@DavidLievrouw DavidLievrouw commented Mar 15, 2020

Add ability to specify scheme of ServiceProviderConfiguration, for use in the ConsulClientFactory

Recreation of #960 after request from @TomPallister.

Fixes / New Feature #959

In the ConsulClientFactory class, the scheme of the Consul server address is hard-coded to "http". In our environment, Consul is not hosted over http, only over https.

Proposed Changes

  • Add property "Scheme" to ServiceProviderConfiguration.
  • Use it in ConsulClientFactory, by adding it to ConsulRegistryConfiguration.
  • Implement a backward compatibility fallback to "http".
  • Make sure it is filled in when loading the GlobalConfiguration from file.

@TomPallister TomPallister merged commit c8c3d12 into ThreeMammals:master Apr 12, 2020
@TomPallister
Copy link
Member

@DavidLievrouw sorry it has taken me so long to merge this PR.

Thank you very much for your contribution to Ocelot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants