Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#827 #1679 Improve performance of Request Mapper #1724

Merged
merged 23 commits into from
Dec 13, 2023
Merged

#827 #1679 Improve performance of Request Mapper #1724

merged 23 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. using ArrayPool<byte> instead of memorystream CopyToAsync

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    002d678 View commit details
    Browse the repository at this point in the history

  2. Maybe this could be a solution. It should be checked. Adding StreamHt… 

    …tpContent (yarp)
    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    563fe86 View commit details
    Browse the repository at this point in the history

  3. little bit of cleanup here

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    69151c0 View commit details
    Browse the repository at this point in the history

  4. Avoiding ToLower() in IsSupportedHeader, using StringComparer.Ordinal… 

    …IgnoreCase
    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    bf266dc View commit details
    Browse the repository at this point in the history

  5. for smaller payloads, avoid allocating a buffer that is larger than t… 

    …he announced content length
    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    810b42d View commit details
    Browse the repository at this point in the history

  6. adding some unit tests for stream http content tests

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5054a02 View commit details
    Browse the repository at this point in the history

  7. typo

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    ef54ad1 View commit details
    Browse the repository at this point in the history

  8. GivenThereIsAPossiblyBrokenServiceRunningOn

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    073a7be View commit details
    Browse the repository at this point in the history

  9. Some code refactorings after code review. There are still some todos,… 

    … but providing some more improvements, removing the exception handling from RequestMapper. It's handled in the middleware now, we will need to analyze this in detail.
    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9461272 View commit details
    Browse the repository at this point in the history

  10. Some code cleanup

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fb4271f View commit details
    Browse the repository at this point in the history

  11. removing some commented code bits

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a2777de View commit details
    Browse the repository at this point in the history

  12. adding more information in InvalidOperationException

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6c1e338 View commit details
    Browse the repository at this point in the history

  13. changing some methods signatures in request mapper, making them static.

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0e6e71f View commit details
    Browse the repository at this point in the history

  14. code review

    @raman-m @ggnaegi
    raman-m authored and ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a9c2465 View commit details
    Browse the repository at this point in the history

  15. Update gotchas.rst

    @raman-m @ggnaegi
    raman-m authored and ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    df2d209 View commit details
    Browse the repository at this point in the history

  16. Update notsupported.rst

    @raman-m @ggnaegi
    raman-m authored and ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    95161d4 View commit details
    Browse the repository at this point in the history

  17. Update gotchas.rst 

    Add "Maximum request body size" notes
    @raman-m @ggnaegi
    raman-m authored and ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b669552 View commit details
    Browse the repository at this point in the history

  18. With this fix, the system is able to handle content with size > 2 Gb

    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9e8a0a8 View commit details
    Browse the repository at this point in the history

  19. adding new benchmarks, generating the payloads on the fly, from 1KB t… 

    …o 1024MB
    @ggnaegi
    ggnaegi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    26b76d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Review PayloadBenchmarks

    @raman-m
    raman-m committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    329c575 View commit details
    Browse the repository at this point in the history

  2. valid JSON

    @raman-m
    raman-m committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8de9fac View commit details
    Browse the repository at this point in the history

  3. should make sure the payloads directory exists

    @ggnaegi
    ggnaegi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    4af64b3 View commit details
    Browse the repository at this point in the history

  4. Payloads folder name should match test method name

    @raman-m
    raman-m committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7958543 View commit details
    Browse the repository at this point in the history