#749 Bad error handling for IOException while reading incoming request body
#1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggnaegi
changed the title
ggnaegi
changed the title
|
@raman-m I just added a skippable fact, since httpsys is compatible with Windows platform only. |
ks1990cn
approved these changes
Oct 31, 2023
|
Please, resolve conflicts! |
ggnaegi
force-pushed
the
bug/749_Bad_error_handling_for_IOException_while_reading_incoming_request_body
branch
from
78a5c54
to
d65d9ac
Compare
|
@raman-m you can review it, code is not great, but it's working. I propose reviewing the exception handling later... |
RaynaldM
approved these changes
Dec 14, 2023
|
@ggnaegi Please resolve conflicts and rebase onto develop! |
|
@raman-m Yes, it can be part of Jan 24 Release |
|
@ggnaegi Please resolve conflicts! |
…two acceptance tests for kestrel and http sys.
…of the exception handling is needed.
ggnaegi
force-pushed
the
bug/749_Bad_error_handling_for_IOException_while_reading_incoming_request_body
branch
from
629ccb2
to
21113db
Compare
raman-m
changed the title
IOException while reading incoming request body
raman-m
approved these changes
Mar 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749
The error handling in ocelot is hiding the 413 payload too large exception. As @raman-m pointed out, a deeper error handling review is needed. Here, I have implemented a quick fix to this issue and I would recommend opening a new issue for the error handling review.
Proposed Changes
BadHttpRequestExceptionand if status code == 413, then returning aPayloadTooLargeError