#649 Acceptance tests #1846
#649 Acceptance tests #1846
Conversation
| [Theory] | ||
| [InlineData("/products")] | ||
| [InlineData("/products/")] | ||
| [Trait("Issue","Should fix issue 649")] |
There was a problem hiding this comment.
@raman-m Here I am using Trait attribute here with Issue key.
Trait have key,value feature which provides easy way to filter out issue category verification test cases.
I am not writing another test case with method name "should_fix_issue_649", cause it will be eventually same by execution.
We can categorize with Issue key when we do verification from checkbox filter in test explorer.
There was a problem hiding this comment.
What are your thoughts on it @raman-m ?
There was a problem hiding this comment.
[Trait] is a nice feature of xUnit! Make sense to use...
There was a problem hiding this comment.
Officially it is better to have separate tests for the issue to close it finally
|
Reviewing... |
raman-m
changed the title
|
Congrats, Tanmay! 🥳 This is your first merged PR! 🎉 |
Fixes #649
Modifying acceptance test case as per issue.
Proposed Changes