-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#740 #1580 Support multiple authentication schemes in one route #1870
#740 #1580 Support multiple authentication schemes in one route #1870
Conversation
Co-authored-by: Raynald Messié <redbird_project@yahoo.fr>
Co-authored-by: Raynald Messié <redbird_project@yahoo.fr>
Merge 'ThreeMammals:develop' into 'develop'
@ggnaegi @RaynaldM @MayorSheFF Please share your opinion ASAP ❗ |
@raman-m I'm not a fan of the language approach with delimiters. You will need a parser for that, with some risks. I would recommend keeping the variant proposed by @MayorSheFF and mark the property AuthenticationProviderKey as deprecated. |
@raman-m I don't think I'm qualified to give an opinion (we don't use auth through the gateway). |
@ggnaegi Good, make sense... Everyone loves their own design... Seems it is too late to change design. But the property is not deprecated. We still consider it as primary auth key, because of backward compatibility. |
Yes mark it obsolete, so we promote the new approach but backward compatibility is ensured. |
@MayorSheFF could you give me the permissions on your PR so I can finish the last steps? Thanks ggnaegi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Complete! 🟢
- Code review ➕➕➕
- High quality source code ➕
- Unit tests ➕
- Acceptance tests ➕
- Updated Docs ➕
- Release notes ❔
The build is 🟢 Ready for delivery! ✔️ |
Closes #1580 #740
Proposed Changes