Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/consul poller option #899

Merged
merged 6 commits into from
May 23, 2019
Merged

Fix/consul poller option #899

merged 6 commits into from
May 23, 2019

Conversation

aliprogrammer69
Copy link
Contributor

Fixes / consul poller option#

Proposed Changes

pollingInterval property of serviceDiscoveryProvider setting is now effective

@thiagoloureiro
Copy link
Contributor

Hello,

  1. Do we need to update documentation to explain how this feature/fix works?
  2. We need unit test the new code, please can you do it?
  3. Integration tests if it's the case too.

@aliprogrammer69
Copy link
Contributor Author

aliprogrammer69 commented May 22, 2019 •
edited
Loading

Hello.
this fix don't need to update documentations.
i created an unit test wiche named "ConsulFileConfigurationPollerOptionTest"

@thiagoloureiro thiagoloureiro merged commit 5b02fb7 into ThreeMammals:develop May 23, 2019
@aliprogrammer69 aliprogrammer69 deleted the fix/consul-poller-option branch May 23, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliprogrammer69 @thiagoloureiro