-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set AES strength to 256 bit #8249
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @pmario I'm happy with the idea but think it is important that we lay out the backwards compatibility implications. For example, can older versions of TiddlyWiki still open a 256-bit encrypted wiki? |
I just did some drag & drop import test to archived empty.html wikis AES-128 (created with TW v5.3.3) and AES-256 (created with this PR) both work
Neither AES-128 created with TW v5.3.3 nor AES-256 with PR works. -> So backwards compatibility was already broken.
It does not even matter if there is a password. So JSON decode may be broken. |
|
Thanks @pmario I am afraid I don't understand this part. Could you explain the test you performed in more detail? |
The I did take both wikis and import them into the empty wikis listed in the TW archive as shown above. Importing the encrypted wikis works as described above. AES-128 v5.3.3 and AES-256 v5.3.4-pre can not be imported to older wikis starting with TW v5.2.1 This PR does not cause this problem. The problem has been there with v5.3.3 already. |
@Jermolene -- I found the changes that caused the problem |
This PR fixes issue #8248
This PR changes the default AES encryption setting from 128 bit to 256 bit.
I did the following tests Windows 11 - FF latest
Import decryption test