Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiffTextWidget colors to some palettes #8661

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Leilei332
Copy link
Contributor

@Leilei332 Leilei332 commented Oct 4, 2024

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Before:

图片

After:

图片

Copy link

stackblitz bot commented Oct 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Oct 4, 2024

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member

pmario commented Oct 4, 2024

If you have a look at the palette-manager edition: https://wikilabs.github.io/editions/palette-manager/
There are a lot of palettes, that have a WL at the end of the name.

All of them should have DiffText colours assigned. Some feedback would be welcome.

That's a reminder, that I should create a PR for all palettes. Since all of the core palettes have some missing elements.

@Leilei332
Copy link
Contributor Author

There are still a lot of palettes that doesn't have diff-* indexes in the palette manager edition, like the two palettes:

  • Solarized Light/Dark WL
  • Solar Flare WL
  • Spartan Day/Night WL

While those palettes have their own diff colors, which I think can be included in the PR:

  • Nord WL
  • DesertSand WL
  • GruvboxDark WL
  • Twlight WL

@pmario
Copy link
Member

pmario commented Oct 4, 2024

If they do not have the indexes in the palette, they use the default from vanilla. That is intended. But I will have a closer look. I have seen some problems with some dark palettes, where the text is invisible.

@Leilei332 Leilei332 marked this pull request as ready for review October 7, 2024 00:06
@kookma
Copy link
Contributor

kookma commented Oct 7, 2024

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Thank you for using a consistent method for adding new color values! Everywhere you have use 6 chars hex code! Keep going on!

@pmario
Copy link
Member

pmario commented Oct 7, 2024

I think only changing the foreground-colour is not enough. We have to take "colour blindness" into account.

Eg: this is "Nord dark WL" palette: Accessibility setting: Simulate: Protanopia (no red)

image

This is the same setting, that I use with my Palette-Manager edition, with the same Accessibility setting

image

The same screenshot for "normal vision"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants