Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language plugin: add en-PH (English (PH)) as a new translation #8669

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

techmagus
Copy link
Contributor

This update introduces a new translation variant: Philippine English.

  • English (PH)
  • en-PH

Philippine English is a blend of American, Australian, and British English, influenced by local languages and culture. The aim of this translation is twofold:

  1. To restructure sentences for a more familiar tone and style for those fluent in Philippine English.
  2. To standardize the spelling, date formats, and related, according to accepted Philippine English conventions and rules. Where multiple formats exist, we prioritize common local usage.

Copy link

stackblitz bot commented Oct 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Oct 7, 2024

@techmagus It appears that this is your first contribution to the project, welcome.

With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md).

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @techmagus I think this looks good. I notice a few of the strings present in the translation appear to be unmodified from the underlying en-GB translation. That's not necessarily a problem but may make it harder for you to track subsequent updates to the en-GB tiddlers.

I also noticed that you expanded on the definition of CamelCase. From a programming language perspective I understand the distinction, but CamelCase is the common term in the wiki community, and for what it's worth Wikipedia says that the case of the initial letter doesn't matter

languages/en-PH/plugin.info Outdated Show resolved Hide resolved
@techmagus
Copy link
Contributor Author

I notice a few of the strings present in the translation appear to be unmodified from the underlying en-GB translation. That's not necessarily a problem but may make it harder for you to track subsequent updates to the en-GB tiddlers.

Oh, those are the em and en dashes. Hmm… you are correct, it's going to be harder, I removed almost all of the em/en/regular dash style changes. ^_^

I also noticed that you expanded on the definition of CamelCase. From a programming language perspective I understand the distinction, but CamelCase is the common term in the wiki community, and for what it's worth Wikipedia says that the case of the initial letter doesn't matter

I see. Yes, I was thinking on being precise on it, but you're right, outside of programming it refers to both. Thank you for the insight. 🙇🏽

Thank you again!

Copy link

github-actions bot commented Oct 8, 2024

techmagus has signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Thanks @techmagus feel free to follow up with further PRs.

@Jermolene Jermolene merged commit 41b9f62 into TiddlyWiki:master Oct 8, 2024
3 checks passed
Leilei332 added a commit to Leilei332/TiddlyWiki5 that referenced this pull request Oct 11, 2024
A small fix for two problems introduced TiddlyWiki#8669.

* Two tab should be used to indent instead of four spaces in
  `tiddlywiki.info` in full edition.
* Changed description for `en-PH`. Since "PH" isn't a country name like
  "US", it should be "Philippines".
Jermolene pushed a commit that referenced this pull request Oct 11, 2024
A small fix for two problems introduced #8669.

* Two tab should be used to indent instead of four spaces in
  `tiddlywiki.info` in full edition.
* Changed description for `en-PH`. Since "PH" isn't a country name like
  "US", it should be "Philippines".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants