Make sure bad links in router methods resolve in production (vercel#1…

…5135)

edge-case I introduced in vercel#14827

packages/next/next-server/lib/router/router.ts

@@ -471,7 +471,7 @@ export default class Router implements BaseRouter {
 
       const parsed = tryParseRelativeUrl(url)
 
-      if (!parsed) return
+      if (!parsed) return resolve(false)
 
       let { pathname, searchParams } = parsed
       const query = searchParamsToUrlQuery(searchParams)

test/integration/invalid-href/pages/third.js

@@ -0,0 +1,26 @@
+import { useRouter } from 'next/router'
+import { useState } from 'react'
+
+const invalidLink = 'https://vercel.com/'
+
+export default () => {
+  const { query, ...router } = useRouter()
+  const [isDone, setIsDone] = useState(false)
+  const { method = 'push' } = query
+
+  function click(e) {
+    router[method](invalidLink).then(
+      () => setIsDone(true),
+      () => setIsDone(true)
+    )
+  }
+
+  return (
+    <>
+      <button id="click-me" onClick={click}>
+        Click me
+      </button>
+      {isDone ? <div id="is-done">Done</div> : null}
+    </>
+  )
+}

test/integration/invalid-href/test/index.test.js

@@ -190,5 +190,17 @@ describe('Invalid hrefs', () => {
         )
       ).toBeTruthy()
     })
+
+    it('makes sure that router push with bad links resolve', async () => {
+      const browser = await webdriver(appPort, '/third')
+      await browser.elementByCss('#click-me').click()
+      await browser.waitForElementByCss('#is-done')
+    })
+
+    it('makes sure that router replace with bad links resolve', async () => {
+      const browser = await webdriver(appPort, '/third?method=replace')
+      await browser.elementByCss('#click-me').click()
+      await browser.waitForElementByCss('#is-done')
+    })
   })
 })