Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Java format validation reports failure explicitly #892

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Ensure Java format validation reports failure explicitly #892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ci(github-actions): 👷 ensure Java format validation reports failure e… 
…xplicitly

Adjust the Java format validation workflow to report failures explicitly during the Spring
project setup. Removed the continue-on-error action and the Check format validation result
step, as they are no longer needed with the updated logic. This change will now give a clear
indication when the format validation fails, requiring contributors to address formatting issues before merging their pull requests.
  • Loading branch information
@linwumingshi
linwumingshi committed Aug 17, 2024
commit 4bcd9fc7900dfd096c2bdd03bb03956893e0600b
12 changes: 1 addition & 11 deletions .github/workflows/spring-javaformat-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,4 @@ jobs:
id: format-validation
run: |
echo "Executing Spring code format validation"
mvn spring-javaformat:validate
continue-on-error: true

- name: Check format validation result
if: always()
run: |
echo "Checking format validation result"
if [ ${{ steps.format-validation.outcome }} == 'failure' ]; then
echo "Spring code format validation failed, please run `spring-javaformat:apply` to fix and resubmit"
exit 1
fi
mvn spring-javaformat:validate