Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The existing Tooljet Helm Chart lacks support for Kubernetes ingress, hindering users who seek to manage access to HTTP and HTTPS routes from outside their cluster to services within the cluster. The implementation of an ingress setup enhances the usability and flexibility of the deployment within Kubernetes environments, enabling URL routing and load balancing functionalities.
Proposed Changes:
1. Ingress Configuration:
Introduces ingress.yaml to define the ingress resource, aligning with common routing and load balancing practices.
2. Values Customization:
Modifies values.yaml to accommodate new ingress settings, ensuring compatibility and extending configurability to users.
3. Helper Functionality:
Implements a helper file to simplify the naming convention and variable reference, enhancing code maintainability and readability.
4. Service Name Adjustment:
Refactors the service name of the app to ensure consistency and clear reference within the Kubernetes environment.
5. Chart Version Update:
Upgrades the chart version to 2.6.1 to reflect the new changes and ensure versioning adherence.
Tasks:
Testing:
To validate the effectiveness and correctness of the proposed modifications, consider performing the following tests:
Deploy the helm chart with the new ingress configuration and validate routing and accessibility.
Validate compatibility and proper referencing with updated values.yaml and service name across different deployment scenarios.
AWS EKS
GCP GKE
Azure AKS