Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ingress Support #13

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Add Ingress Support #13

merged 9 commits into from
Oct 6, 2023

Conversation

martinibach
Copy link
Contributor

Motivation:

The existing Tooljet Helm Chart lacks support for Kubernetes ingress, hindering users who seek to manage access to HTTP and HTTPS routes from outside their cluster to services within the cluster. The implementation of an ingress setup enhances the usability and flexibility of the deployment within Kubernetes environments, enabling URL routing and load balancing functionalities.

Proposed Changes:

1. Ingress Configuration:

Introduces ingress.yaml to define the ingress resource, aligning with common routing and load balancing practices.

2. Values Customization:

Modifies values.yaml to accommodate new ingress settings, ensuring compatibility and extending configurability to users.

3. Helper Functionality:

Implements a helper file to simplify the naming convention and variable reference, enhancing code maintainability and readability.

4. Service Name Adjustment:

Refactors the service name of the app to ensure consistency and clear reference within the Kubernetes environment.

5. Chart Version Update:

Upgrades the chart version to 2.6.1 to reflect the new changes and ensure versioning adherence.

Tasks:

  • Add ingress.yaml for ingress configuration.
  • Update values.yaml to ensure compatibility with new ingress setup.
  • Introduce helper file for simplified variable naming.
  • Modify the service name of the app for coherent referencing.
  • Bump the chart version to 2.6.1.

Testing:

To validate the effectiveness and correctness of the proposed modifications, consider performing the following tests:

  • Deploy the helm chart with the new ingress configuration and validate routing and accessibility.

  • Validate compatibility and proper referencing with updated values.yaml and service name across different deployment scenarios.

  • AWS EKS

  • GCP GKE

  • Azure AKS

@martinibach martinibach marked this pull request as ready for review October 4, 2023 09:52
@Hokwang
Copy link

Hokwang commented Oct 6, 2023

@adishM98 please take care helm chart repo. lots of improve needed for tooljet.

@adishM98 adishM98 merged commit c4e57af into ToolJet:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants