Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo documentation #63

Merged
merged 6 commits into from
Jul 1, 2021
Merged

Redo documentation #63

merged 6 commits into from
Jul 1, 2021

Conversation

jpbberry
Copy link
Member

@jpbberry jpbberry commented Jun 20, 2021

This PR adds TypeDoc as the docs builder and publisher.

Steps needed before merge
- Empty docs branch made
- Add CNAME into the docs branch with the contents

In draft while workflow for deploying docs with @top-gg-bot is being created.

@jpbberry
Copy link
Member Author

@Xetera any idea why these checks are failing? Works fine on my repo, never worked with ataylorme/eslint-annotate-action

@Xetera
Copy link
Contributor

Xetera commented Jun 21, 2021

Looks like PRs don't have access to the github token by default. There's a workaround here but it seems kind of tedious. I'll disable the annotation for now and just run regular eslint instead

@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for jolly-benz-150468 ready!

🔨 Explore the source changes: 1296a45

🔍 Inspect the deploy log: https://app.netlify.com/sites/jolly-benz-150468/deploys/60de08c3dd295a0007836d22

😎 Browse the preview: https://deploy-preview-63--jolly-benz-150468.netlify.app

@jpbberry jpbberry marked this pull request as ready for review June 29, 2021 17:59
@jpbberry jpbberry requested review from Xetera and velddev June 29, 2021 17:59
README.md Show resolved Hide resolved
src/structs/Api.ts Outdated Show resolved Hide resolved
src/typings.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Xetera Xetera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the docs update

@jpbberry jpbberry merged commit dc11a35 into Top-gg-Community:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants