Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed member subscription details in Admin #20619

Merged
merged 1 commit into from
Jul 18, 2024
Merged

🐛 Fixed member subscription details in Admin #20619

merged 1 commit into from
Jul 18, 2024

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Jul 18, 2024

fixes https://linear.app/tryghost/issue/ONC-189

  • commit 4084a3d introduced a regression that caused member subscription details to not be rendered for active/canceled subscriptions
  • with this fix, the rendering logic in Admin for member subscription details has been fully moved to a helper and is now covered by additional unit tests

@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Jul 18, 2024
fixes https://linear.app/tryghost/issue/ONC-189

- commit 4084a3d introduced a regression that caused member subscription details to not be rendered in Admin for paid subscriptions
- with this fix, the subscription details rendering logic has been fully moved to a helper and is now covered by additional unit tests
@sagzy sagzy merged commit c5bb2e5 into main Jul 18, 2024
19 checks passed
@sagzy sagzy deleted the fix/ONC-189 branch July 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant