Added MultiLineString support for @turf/point-on-line #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added multiLineString test; updated relevant files;
jbccollins
approved these changes
Jul 12, 2017
packages/turf-point-on-line/index.js
Outdated
| throw new Error('input must be a LineString Feature or Geometry'); | ||
| module.exports = function (lines, pt, units) { | ||
| // validation | ||
| if (lines.type !== 'Feature' && lines.type !== 'LineString' && lines.type !== 'MultiLineString' && lines.geometry.type !== 'LineString' && lines.geometry.type !== 'MultiLineString') { |
There was a problem hiding this comment.
Condensed this validation step to this:
var type = (lines.geometry) ? lines.geometry.type : lines.type;
if (type !== 'LineString' && type !== 'MultiLineString') {
throw new Error('lines must be LineString or MultiLineString');
}There was a problem hiding this comment.
🤦♂️ of course! Dumb me 😅
There was a problem hiding this comment.
No no... it's just simpler to read this way.
There was a problem hiding this comment.
exactly!
simpler => better!! 😃
packages/turf-point-on-line/index.js
Outdated
| * | ||
| * @name pointOnLine | ||
| * @param {Feature<LineString>} line line to snap to | ||
| * @param {Feature<LineString>|Feature<MultiLineString>} lines lines to snap to |
There was a problem hiding this comment.
To support both Feature & Geometry, so far the JSDocs have been declared like this:
/**
* @param {Geometry|Feature<LineString|MultiLineString>} lines lines to snap to
* @param {Geometry|Feature<Point>|number[]} pt point to snap from
- Improved Typescript Definition with additional properties - Added Typescript tets - Added Geometry tests
DenisCarriere
requested changes
Jul 12, 2017
|
Using happening when the point is between the MultiLineString. |
|
Fixed with
Added also a more complex test: |
DenisCarriere
approved these changes
Jul 13, 2017
|
@stebogit Awesome! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835
Still the module returns a single
point, the closest of all thelinesof theMultiLineString.Is it correct?
CC: @jbccollins @DenisCarriere