Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed example parsing for joi version > 14 #52

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

lucasconstantino
Copy link
Contributor

@bkulyk
Copy link

bkulyk commented Feb 26, 2019

👍

@Romakita
Copy link

Hello everybody :),

The bug affect our project also. It's possible to merge this PR, pleassseeeee :D ?

Thanks guys for your job ;)
Romain

@renatoargh
Copy link

Hey guys, any ETA on this merge? PR is already several months old! Would be very helpful!

@Mairu
Copy link
Collaborator

Mairu commented Jun 17, 2019

Well because it seemed that it could take some while, I created a fork where this and other PRs are merged. https://github.com/Mairu/joi-to-swagger / https://www.npmjs.com/package/@mairu/joi-to-swagger

@bkulyk
Copy link

bkulyk commented Jun 18, 2019

@Twipped have you abandoned this project. It still seems to get a lot of traffic on mom and could use some enhancements. Can you please review this PR?

@Twipped
Copy link
Owner

Twipped commented Jun 19, 2019

Not abandoned, just don't have time to work on it. I originally wrote it for an api service we had at work, but we've now replaced that project with a graphql server. If somebody wants to come on as collab I'd be willing to add them to the repo and npm package.

@Mairu
Copy link
Collaborator

Mairu commented Jun 20, 2019

Well if wanted, I could do that @Twipped

@Twipped
Copy link
Owner

Twipped commented Jun 20, 2019

@Mairu Done, you're added as a collaborator. Is Mairu your npm username as well?

@Mairu
Copy link
Collaborator

Mairu commented Jun 20, 2019

@Mairu Done, you're added as a collaborator. Is Mairu your npm username as well?

Thanks. It is https://www.npmjs.com/~mairu-master. And for all that are waiting, I have vacation from tomorrow on. So it could take one more week until I have time to do some stuff.

@Twipped
Copy link
Owner

Twipped commented Jun 20, 2019

@Mairu you now have publish rights.

@bkulyk
Copy link

bkulyk commented Jun 20, 2019

@Twipped @Mairu thanks folks! 👏 I'm glad to see we're going that have a maintainer on this.

@Mairu Mairu merged commit f36f38e into Twipped:master Jul 4, 2019
@Mairu Mairu mentioned this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants