-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper: Make codeResources and useDiffEditor optional in EditorAppConfig #670
Conversation
- Update dependencies along
- Added eslint rules @typescript-eslint/strict-boolean-expressions and @typescript-eslint/no-unnecessary-condition - Updated dependencies once more
@CGNonofr eslint produces errors I don't see on Windows, but only on Linux. I can reproduce this locally. |
@CGNonofr I got it. Code from the dependent packages in the repo are not available. Type resolution is therefore not correct. The code needs to be built first. |
@CGNonofr problems are resolved. This is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes :)
With latest changes it is now also possible to remove any
codeResources
oruseDiffEditor
from the editor app configuration.Dependencies were updated as well