Wait for Monaco to initialize when MonacoEditorReactComp props are updated #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrama628
force-pushed
the
react-component-did-update
branch
from
cc6ac47
to
78b60a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681 and fixes #622
In
MonacoEditorReactCompthere's a race condition between the Monaco editor initializing and the component rerendering; if a component rerenders and triggerscomponentDidUpdatebefore Monaco has finished initializing, errors happen as described in the linked issue.The first commit introduces a test that exhibits these errors, and the second commit fixes it by awaiting
this.isRestartingincomponentDidUpdate.