Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "Dispose extension files in EditorAppExtended" #688

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

vrama628
Copy link
Contributor

This is a test case for #680; we don't yet know how to get this test to work properly without unrelated errors happening, so I've moved it to a separate draft PR as requested.

@kaisalmen kaisalmen marked this pull request as ready for review July 12, 2024 13:51
@kaisalmen
Copy link
Collaborator

kaisalmen commented Jul 12, 2024

@vrama628 please rebase to latest main. This test works out of the box with vitest v2. I just tested this locally.

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen kaisalmen merged commit ffff522 into TypeFox:main Jul 12, 2024
1 check failed
@kaisalmen
Copy link
Collaborator

@vrama628 nevermind. I just squashed merged the change to the top. Thank you for you contribution.

@kaisalmen
Copy link
Collaborator

The test only works on Windows, but not on Linux. I disabled it again for now.

@kaisalmen
Copy link
Collaborator

Vitest browser mode is still under development, but it worked already better than any other solution I tried. We just have to wait or I will open up an issue. Let's see.

@kaisalmen
Copy link
Collaborator

@vrama628 and @CGNonofr the test only fails in headless mode on Linux. It works locally without.

@kaisalmen
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants