Support all arguments for monaco-vscode-api initialize #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figure editor-, view- or workspace-service (preperation for further extension)
kaisalmen
changed the title
kaisalmen
changed the title
CGNonofr
reviewed
Oct 4, 2024
kaisalmen
force-pushed
the
env-views-options
branch
from
173a301
to
fcfc889
Compare
CGNonofr
reviewed
Oct 4, 2024
kaisalmen
force-pushed
the
env-views-options
branch
from
fcfc889
to
ff65e20
Compare
- Wrapper: If semantic highlight is configured in editorOptions it is set to workspaceConfig.configurationDefaults
kaisalmen
force-pushed
the
env-views-options
branch
from
108b741
to
bc7b1dc
Compare
kaisalmen
force-pushed
the
env-views-options
branch
from
ed037a5
to
fd90281
Compare
|
@CGNonofr this is now ready. |
CGNonofr
reviewed
Oct 6, 2024
CGNonofr
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support all arguments for monaco-vscode-api initialize implements CodinGame/monaco-vscode-api#371
This also allows to configure editor-, view- or workspace-service. This is a preparation for further enhancements.
The
htmlContaineris now configured at a single place and has become mandatory. This is also a preparation for future enhancements.@CGNonofr I needed to bring back the workaround for semantic highlighting when the classic/monarch config is used. This time the config is augmented.