Make ts-loader compatible with node v6 #202
Conversation
Node 6+ enforces the parameter to path.dirname to be a string (nodejs/node@08085c4). The empty string results in the previous behavior.
|
I'll leave this to @jbrantly to merge but I wanted to be clear as to the problem this solves. Does ts-loader not work with node 6? I haven't tried it myself... |
|
That's right - at least in my context where that config file parameter was not used. |
|
I have been upgrading several web pack loaders in the last week after switching to node 6 in my projects. All of them had very similar issues. Btw: seems like some other user also reported this (last comment here: #115). |
|
I've been using ts-loader in quill and looks like node v6 with ts-loader is causing build errors. The code changes in this PR fixes the issue. |
|
I think we should merge this; it's minor and backwards compatible .@jbrantly are you happy with this? |
johnnyreilly
changed the title
johnnyreilly
changed the title
|
any update on this issue? |
|
Merged - sorry about the delay. I'm not sure when @jbrantly next hopes to publish but it'll be in the next release. |
Node 6+ enforces the parameter to path.dirname to be a string (nodejs/node@08085c4). The empty string results in the previous behavior.