Skip to content

Commit

Permalink
code refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
UbeydeKara committed Jun 15, 2023
1 parent 7a08041 commit af05bff
Show file tree
Hide file tree
Showing 32 changed files with 92 additions and 94 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.basedomain.payload;
package com.ubeydekara.base.payload;

import lombok.AllArgsConstructor;
import lombok.Builder;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.basedomain.payload;
package com.ubeydekara.base.payload;

import lombok.AllArgsConstructor;
import lombok.Builder;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.basedomain.response;
package com.ubeydekara.base.response;

import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.discoveryservice;
package com.ubeydekara.discovery;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
Expand Down
1 change: 0 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ services:
KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1
KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1

networks:
- spring

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.ubeydekara.emailservice;
package com.ubeydekara.email;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.client.discovery.EnableDiscoveryClient;

@SpringBootApplication(scanBasePackages = {
"com.ubeydekara.emailservice",
"com.ubeydekara.email",
"com.ubeydekara.kafka"}
)
@EnableDiscoveryClient
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.ubeydekara.emailservice.controller;
package com.ubeydekara.email.controller;

import com.ubeydekara.basedomain.payload.EmailPayload;
import com.ubeydekara.basedomain.response.ResponseHandler;
import com.ubeydekara.emailservice.model.Email;
import com.ubeydekara.emailservice.service.EmailService;
import com.ubeydekara.base.payload.EmailPayload;
import com.ubeydekara.base.response.ResponseHandler;
import com.ubeydekara.email.model.Email;
import com.ubeydekara.email.service.EmailService;
import lombok.RequiredArgsConstructor;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.emailservice.model;
package com.ubeydekara.email.model;

import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.ubeydekara.emailservice.repository;
package com.ubeydekara.email.repository;

import com.ubeydekara.emailservice.model.Email;
import com.ubeydekara.email.model.Email;
import org.springframework.data.jpa.repository.JpaRepository;

import java.util.UUID;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.ubeydekara.email.service;

import com.ubeydekara.base.payload.EmailPayload;
import com.ubeydekara.email.model.Email;

import java.util.List;

public interface EmailService {
List<Email> getAll();

Email send(EmailPayload emailPayload);
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.ubeydekara.emailservice.service;
package com.ubeydekara.email.service;

import com.ubeydekara.basedomain.payload.EmailPayload;
import com.ubeydekara.emailservice.model.Email;
import com.ubeydekara.emailservice.repository.EmailRepository;
import com.ubeydekara.base.payload.EmailPayload;
import com.ubeydekara.email.model.Email;
import com.ubeydekara.email.repository.EmailRepository;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Value;
Expand All @@ -11,6 +11,7 @@
import org.springframework.mail.javamail.JavaMailSender;
import org.springframework.stereotype.Service;

import java.time.LocalDateTime;
import java.util.List;

@Slf4j
Expand All @@ -29,7 +30,7 @@ public List<Email> getAll() {
return emailRepository.findAll();
}

@KafkaListener(topics = "order-email", groupId = "foo")
@KafkaListener(topics = "email", groupId = "order")
public Email send(EmailPayload emailPayload)
{
try {
Expand Down Expand Up @@ -60,6 +61,7 @@ private Email create(EmailPayload emailPayload) {
emailPayload.getProduct(),
emailPayload.getOrderID())
)
.dateTime(LocalDateTime.now())
.build();
}

Expand Down

This file was deleted.

3 changes: 0 additions & 3 deletions email-service/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ spring:
password: <your-password>
port: 587

profiles:
active: default

kafka:
bootstrap-servers: http://localhost:9092

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.gateservice;
package com.ubeydekara.gateway;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
Expand Down
2 changes: 1 addition & 1 deletion gateway-service/src/main/resources/application-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ server:

spring:
application:
name: gate-service
name: gateway-service

cloud:
gateway:
Expand Down
2 changes: 1 addition & 1 deletion gateway-service/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ server:

spring:
application:
name: gate-service
name: gateway-service

cloud:
gateway:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ public class KafkaTopicConfig {

@Bean
public NewTopic orderEmailTopic() {
return TopicBuilder.name("order-email")
return TopicBuilder.name("email")
.build();
}

@Bean
public NewTopic orderStockTopic() {
return TopicBuilder.name("order-stock")
return TopicBuilder.name("stock")
.build();
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.ubeydekara.orderservice;
package com.ubeydekara.order;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.client.discovery.EnableDiscoveryClient;

@SpringBootApplication(scanBasePackages = {
"com.ubeydekara.orderservice",
"com.ubeydekara.order",
"com.ubeydekara.kafka"}
)
@EnableDiscoveryClient
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.ubeydekara.orderservice.controller;
package com.ubeydekara.order.controller;

import com.ubeydekara.basedomain.response.ResponseHandler;
import com.ubeydekara.orderservice.model.Order;
import com.ubeydekara.orderservice.request.OrderRequest;
import com.ubeydekara.orderservice.service.OrderService;
import com.ubeydekara.base.response.ResponseHandler;
import com.ubeydekara.order.model.Order;
import com.ubeydekara.order.request.OrderRequest;
import com.ubeydekara.order.service.OrderService;
import jakarta.validation.Valid;
import lombok.RequiredArgsConstructor;
import org.springframework.http.HttpStatus;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.orderservice.model;
package com.ubeydekara.order.model;

import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.ubeydekara.orderservice.repository;
package com.ubeydekara.order.repository;

import com.ubeydekara.orderservice.model.Order;
import com.ubeydekara.order.model.Order;
import org.springframework.data.jpa.repository.JpaRepository;

import java.util.UUID;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.ubeydekara.orderservice.request;
package com.ubeydekara.order.request;

import lombok.Data;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.ubeydekara.order.service;

import com.ubeydekara.order.model.Order;
import com.ubeydekara.order.request.OrderRequest;

import java.util.List;

public interface OrderService {
List<Order> getAll();
Order create(OrderRequest orderRequest);

}
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.ubeydekara.orderservice.service;
package com.ubeydekara.order.service;

import com.ubeydekara.basedomain.payload.EmailPayload;
import com.ubeydekara.basedomain.payload.StockPayload;
import com.ubeydekara.base.payload.EmailPayload;
import com.ubeydekara.base.payload.StockPayload;
import com.ubeydekara.kafka.service.ProducerService;
import com.ubeydekara.orderservice.model.Order;
import com.ubeydekara.orderservice.repository.OrderRepository;
import com.ubeydekara.orderservice.request.OrderRequest;
import com.ubeydekara.order.model.Order;
import com.ubeydekara.order.repository.OrderRepository;
import com.ubeydekara.order.request.OrderRequest;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;

Expand Down Expand Up @@ -49,7 +49,7 @@ private void notifyStock(Order order) {
.product(order.getProduct())
.quantity(order.getQuantity())
.build();
producerService.sendMessage("order-stock", stockPayload);
producerService.sendMessage("stock", stockPayload);
}

/**
Expand All @@ -64,6 +64,6 @@ private void notifyEmail(Order order) {
.orderID(order.getOrderID())
.product(order.getProduct())
.build();
producerService.sendMessage("order-email", emailPayload);
producerService.sendMessage("email", emailPayload);
}
}

This file was deleted.

3 changes: 0 additions & 3 deletions order-service/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ spring:
format_sql: true
show-sql: true

profiles:
active: default

kafka:
bootstrap-servers: http://localhost:9092

Expand Down
8 changes: 7 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,10 @@ $ mvn clean package -Pbuild-image
Then run all the containers with `docker-compose`:
```shell
$ docker-compose up
```
```

### TODO
- Config Server
- Kafka Streams
- Kubernetes
- JUnit Testing with Mockito
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.ubeydekara.stock.controller;

import com.ubeydekara.basedomain.payload.StockPayload;
import com.ubeydekara.basedomain.response.ResponseHandler;
import com.ubeydekara.base.payload.StockPayload;
import com.ubeydekara.base.response.ResponseHandler;
import com.ubeydekara.stock.model.Stock;
import com.ubeydekara.stock.response.StockResponse;
import com.ubeydekara.stock.service.StockService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.ubeydekara.stock.mapper;

import com.ubeydekara.basedomain.payload.StockPayload;
import com.ubeydekara.base.payload.StockPayload;
import com.ubeydekara.stock.model.Stock;
import org.springframework.stereotype.Component;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.ubeydekara.stock.service;

import com.ubeydekara.basedomain.payload.StockPayload;
import com.ubeydekara.base.payload.StockPayload;
import com.ubeydekara.stock.model.Stock;
import com.ubeydekara.stock.response.StockResponse;

Expand Down
Loading

0 comments on commit af05bff

Please sign in to comment.