Skip to content
This repository has been archived by the owner on Sep 5, 2022. It is now read-only.

Commit

Permalink
Revert "Patch ComTypes with a small fix"
Browse files Browse the repository at this point in the history 
This reverts commit 20f8051.
It didn't work on Windows since there is no 'patch' on Windows. To fix this we'd have to pull in GNU's patch application as an additional dependency and that takes this to an additional level, especially seeing as to how I'm doing all this from an Ubuntu machine...

Contributes to issue CURA-3823.
  • Loading branch information
@Ghostkeeper
Ghostkeeper committed Aug 11, 2017
1 parent 20f8051 commit 7a3ddf1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
1 change: 0 additions & 1 deletion projects/python-comtypes.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ if(BUILD_OS_WINDOWS)
ExternalProject_Add(PythonComtypes
URL https://pypi.python.org/packages/85/11/722b9ce6725bf8160bd8aca68b1e61bd9db422ab12dae28daa7defab2cdc/comtypes-1.1.3-2.zip
URL_MD5 4161cb8bc283a75af85e220ad662d5af
PATCH_COMMAND patch comtypes/__init__.py ${CMAKE_SOURCE_DIR}/cmake/python-comtypes.patch
CONFIGURE_COMMAND ""
BUILD_COMMAND ${PYTHON_EXECUTABLE} setup.py build
INSTALL_COMMAND ${PYTHON_EXECUTABLE} setup.py install --single-version-externally-managed --record=comtypes-install.log
Expand Down
15 changes: 0 additions & 15 deletions projects/python-comtypes.patch
View file

This file was deleted.

2 comments on commit 7a3ddf1

@thopiekar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, jammer!
But thanks for investing time into this!

@Ghostkeeper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might still succeed by forking the project, applying the change manually in the code and then building the module from there, but it's not on my radar right now to spend time on that, especially seeing as how I can't really test it without a Windows development environment.

Please sign in to comment.