Cura 10951 gh build curapackage #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Conanfile for Savitar was expanded, refactored, and updated to use Conan's improved layout(), build(), and package() capabilities. Importantly, the required Conan version was updated, the recipe and related tests were updated to support recent compilers, and overall code organization and standards were improved. The legacy Conan code was also removed to improve readability and maintainability of the script. The test_package was updated to follow these changes. Contributes to CURA-10951
Contributes to CURA-10951
Contributes to CURA-10951
Options are unknown at this time. Contributes to CURA-10951
3 tasks
rburema
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
LGTM. Seems github has a new feature that causes it to complain about already existing xml file headers. I think it's just adding the encoding that it's missing though.
Not sure about the unit-tests. Will have to see if they where already failing. Otherwise we could maybe first merge and then see if they are still happening in 10475? (After merging main in for good measure...)
|
|
||
| required_conan_version = ">=1.50.0" | ||
|
|
||
| required_conan_version = ">=1.56.0" |
There was a problem hiding this comment.
... same as the other comments about this. I should be adding easter eggs to these. 🥇 🥚
done as part of CURA-10951
done as part of CURA-10951
done as part of CURA-10951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.