Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed message commands in CMakeLists.txt, and ncdump dependency problems for tst_nccopy4 in CMake build #2983

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Aug 16, 2024

Fixes #2982
Fixes #2395

@edwardhartnett edwardhartnett changed the title fixed message commands in CMakeLists.txt fixed message commands in CMakeLists.txt, and ncdump dependency problems for tst_nccopy4 in CMake build Aug 16, 2024
@WardF
Copy link
Member

WardF commented Aug 19, 2024

An interesting thing to note about the DEPENDS directive in cmake is that it specifies the order in which tests are run. It does not enforce test X completing before running test Y, even if X is set as a dependency on Y. There is a mechanism around this that I started poking at before leaving for PTO last week, and I will get back to it this week.

@WardF WardF merged commit 26e0b45 into Unidata:main Aug 19, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some message() calls in CMakeLists.txt without first parameter parallel make issue in ncdump tests
2 participants