Remove crispy-forms from VlanFilterForm (again) #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds an alternate display of all search/info forms based on `nav.web.info.forms.SearchForm`, by moving form layout hints into a non-crispy-forms based structure. All forms are displayed twice in a row in order to be able to compare them "side-by-side" (i.e. this is just an intermediate commit)
The prefix search form tries to explicitly set a form element id using crispy-forms. Unsure of why. This adds support for this in the new template based implementation and moves the form id from the crispy version to the non-crispy version.
This removes the crispy version of all info/search forms, and leaves only the new versions.
This updates flat forms to enable the caller to override the form element's id and class tags.
This uses the form mechanisms that were introduced in #3034 to replace crispy-forms.
This reverts commit 0d222f6.
This uses the updated way of removing crispyforms by partially reimplementing it
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 41s ⏱️ Results for commit 703df5a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/add-optional-label-to-submit-field #3065 +/- ##
===============================================================================
- Coverage 60.48% 60.47% -0.01%
===============================================================================
Files 605 605
Lines 43823 43817 -6
Branches 48 48
===============================================================================
- Hits 26506 26500 -6
Misses 17305 17305
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
refactor/improve-uncrispified-vlan-filter-form
branch
from
1d53ff8
to
703df5a
Compare
|
johannaengland
force-pushed
the
refactor/add-optional-label-to-submit-field
branch
from
96b83c3
to
83b2058
Compare
Base automatically changed from
refactor/add-optional-label-to-submit-field
to
master
October 2, 2024 12:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3064 and #3036 to be merged first.
This reverts #2993 and removes crispyforms again using the new way of basically reimplementing crispyforms partially.
Closes #2991.
Url: http://localhost/seeddb/vlan/
Completely removing crispy is only possible after #3062 since it uses the same part of the template.