Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to query delivery fees #3

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

franciscoaguirre
Copy link

The plan is to have this API provide the low-level primitives to allow users to estimate fees.
On top of this, we'll provide a top-level API that lets UIs know the parameters to these low-level APIs.

Copy link

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@PraetorP
Copy link

@franciscoaguirre , a little ahead of me with the implementation :)
Can you please look at our solution (#4)?

@franciscoaguirre
Copy link
Author

franciscoaguirre commented Mar 19, 2024

@PraetorP I think using the validate method is better since it has access to all the configured routers

@franciscoaguirre franciscoaguirre changed the title Add function to query delivery fees and tests Add function to query delivery fees Mar 19, 2024
@franciscoaguirre franciscoaguirre marked this pull request as ready for review March 19, 2024 18:47
@PraetorP PraetorP merged commit 4caea72 into UniqueNetwork:xcm-payment-api-master Mar 20, 2024
2 checks passed
@franciscoaguirre franciscoaguirre deleted the pr3607 branch March 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants