Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for race condition causing crash/white page on the account page #348

Merged
merged 2 commits into from
Mar 19, 2021
Merged

workaround for race condition causing crash/white page on the account page #348

merged 2 commits into from
Mar 19, 2021

Conversation

metjm
Copy link
Contributor

@metjm metjm commented Feb 5, 2021

Some race condition is causing a crash in MiningPositionList when pairData is not set. It has been happening for months on https://uniswap.info/account/[address]

This workaround seems to fix that.

@vercel
Copy link

vercel bot commented Feb 5, 2021

@metjm is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

@xiankaing
Copy link

thank you !

Copy link

@xiankaing xiankaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple workaround but we just need the page to not crash

@xiankaing
Copy link

please merge this 🙏

@metjm
Copy link
Contributor Author

metjm commented Mar 19, 2021

@ianlapham any chance this could be merged? Loading the account page on a good day takes 5 attempts when I'm lucky with the race condition. Often more.

@vercel
Copy link

vercel bot commented Mar 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-info/fn6zV5UtVUftvW3M2uREurwGAiPu
✅ Preview: https://uniswap-info-git-fork-metjm-fix-account-page-crash-uniswap.vercel.app

@metjm
Copy link
Contributor Author

metjm commented Mar 19, 2021

thank you!

@ianlapham
Copy link
Member

@metjm No problem - my notifications are bad here always feel free to hunt me down

@xiankaing
Copy link

xiankaing commented Mar 19, 2021

Hype thanks for merging this
I'll finally not have to cmd+return and open 20 tabs

based on


on:
--
4 | schedule:
5 | - cron: '0 12 * * 1-4' # every day 12:00 UTC Monday-Thursday

we'll see this live in about 65 hours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants