-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workaround for race condition causing crash/white page on the account page #348
Conversation
@metjm is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple workaround but we just need the page to not crash
please merge this 🙏 |
@ianlapham any chance this could be merged? Loading the account page on a good day takes 5 attempts when I'm lucky with the race condition. Often more. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-info/fn6zV5UtVUftvW3M2uREurwGAiPu |
thank you! |
@metjm No problem - my notifications are bad here always feel free to hunt me down |
Hype thanks for merging this based on
we'll see this live in about 65 hours? |
Some race condition is causing a crash in MiningPositionList when pairData is not set. It has been happening for months on
https://uniswap.info/account/[address]
This workaround seems to fix that.