Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate metadata #78

Merged
merged 1 commit into from
May 18, 2020
Merged

Generate metadata #78

merged 1 commit into from
May 18, 2020

Conversation

chriseth
Copy link
Contributor

The compilation metadata is essential to establish a link between the deployed bytecode and the source code. It is crucial that it is made available so that users can re-compile and verify the smart contracts.

@NoahZinsmeister
Copy link
Contributor

@moodysalem this may warrant a 1.0.1 release, what do you think?

@moodysalem
Copy link
Contributor

@moodysalem this may warrant a 1.0.1 release, what do you think?

Yeah it doesn’t hurt, and we can put the network addresses in the build json artifacts too if we want

@NoahZinsmeister
Copy link
Contributor

ok, want to take point on this? rough action plan:

  1. pull this PR down
  2. generate new artifacts (potentially adding the addresses if it makes sense)
  3. bump to 1.0.1
  4. release
  5. push back to this PR
  6. squash + merge

@moodysalem moodysalem merged commit 5419f54 into Uniswap:master May 18, 2020
@moodysalem
Copy link
Contributor

moodysalem commented May 18, 2020

Figured it's not worth in the end unless it's automated, since we're likely to forget the next time we publish

Edit: to clarify I’m referring to adding the network addresses to the compiler output, this PR was merged and a 1.0.1 release was created

@chriseth
Copy link
Contributor Author

@moodysalem I'm not sure what you deem "not worth", but if it is the 1.0.1 release, then please at least publish the metadata of the 1.0.0 release. Since building is automated, it should not be too hard to re-created it. The main thing to keep in mind is that the paths need to be the same as in the original compilation.

@moodysalem
Copy link
Contributor

moodysalem commented May 19, 2020

Why do you need the compiler settings of 1.0.0? Everything except this PR and the output of metadata should be exactly the same and verify against the smart contracts we have deployed and the compiled bytecode

Edit: Sorry I had just woken up, I see the misunderstanding now, when I said “not worth” i was referring to adding the addresses to the compiler output. I did a 1.0.1 release with this PR included

@chriseth
Copy link
Contributor Author

Ah I see! Indeed it matches! Thanks a lot!

@chriseth
Copy link
Contributor Author

0xBeaver pushed a commit to 0xBeaver/uniswap-v2-core that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants