-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate metadata #78
Conversation
@moodysalem this may warrant a |
Yeah it doesn’t hurt, and we can put the network addresses in the build json artifacts too if we want |
ok, want to take point on this? rough action plan:
|
Figured it's not worth in the end unless it's automated, since we're likely to forget the next time we publish Edit: to clarify I’m referring to adding the network addresses to the compiler output, this PR was merged and a 1.0.1 release was created |
@moodysalem I'm not sure what you deem "not worth", but if it is the 1.0.1 release, then please at least publish the metadata of the 1.0.0 release. Since building is automated, it should not be too hard to re-created it. The main thing to keep in mind is that the paths need to be the same as in the original compilation. |
Why do you need the compiler settings of 1.0.0? Everything except this PR and the output of metadata should be exactly the same and verify against the smart contracts we have deployed and the compiled bytecode Edit: Sorry I had just woken up, I see the misunderstanding now, when I said “not worth” i was referring to adding the addresses to the compiler output. I did a 1.0.1 release with this PR included |
Ah I see! Indeed it matches! Thanks a lot! |
Added the factory here: https://contractrepo.komputing.org/contract/mainnet/0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f/ |
The compilation metadata is essential to establish a link between the deployed bytecode and the source code. It is crucial that it is made available so that users can re-compile and verify the smart contracts.