Skip to content

Commit

Permalink
Removed the upper clamp values for recursive rendering and light clus…
Browse files Browse the repository at this point in the history
…ter size (case 1294620) (#2753)

* - Removed the superior clamping value for the recursive rendering max ray length.
- Removed the superior clamping value for the ray tracing light cluster size.

* minor change
  • Loading branch information
anisunity committed Dec 14, 2020
1 parent ea817bc commit 64a4568
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 2 additions & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Changed
- Removed the material pass probe volumes evaluation mode.
- Volume parameter of type Cubemap can now accept Cubemap render textures and custom render textures.
- Removed the superior clamping value for the recursive rendering max ray length.
- Removed the superior clamping value for the ray tracing light cluster size.

## [10.3.0] - 2020-12-01

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using UnityEngine;
using UnityEditor.Rendering;
using UnityEditor.Rendering.HighDefinition;
using UnityEngine.Rendering.HighDefinition;
using UnityEngine.Rendering;

namespace UnityEditor.Experimental.Rendering.HighDefinition
{
Expand All @@ -26,6 +26,8 @@ public override void OnEnable()
m_MinSmoothness = Unpack(o.Find(x => x.minSmoothness));
}

static public readonly GUIContent k_RayLengthText = EditorGUIUtility.TrTextContent("Max Ray Length", "This defines the maximal travel distance of rays.");

public override void OnInspectorGUI()
{
HDRenderPipelineAsset currentAsset = HDRenderPipeline.currentAsset;
Expand All @@ -47,7 +49,7 @@ public override void OnInspectorGUI()
{
PropertyField(m_LayerMask);
PropertyField(m_MaxDepth);
PropertyField(m_RayLength);
PropertyField(m_RayLength, k_RayLengthText);
PropertyField(m_MinSmoothness);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public sealed class LightCluster : VolumeComponent
/// Controls the range of the cluster around the camera.
/// </summary>
[Tooltip("Controls the range of the cluster around the camera.")]
public ClampedFloatParameter cameraClusterRange = new ClampedFloatParameter(10f, 0.001f, 50f);
public MinFloatParameter cameraClusterRange = new MinFloatParameter(10.0f, 0.001f);
/// <summary>
/// Default constructor for the light cluster volume component.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ public sealed class RecursiveRendering : VolumeComponent
/// <summary>
/// This defines the maximal travel distance of rays.
/// </summary>
[Tooltip("Ray Length. This defines the maximal travel distance of rays.")]
public ClampedFloatParameter rayLength = new ClampedFloatParameter(10f, 0f, 50f);
public MinFloatParameter rayLength = new MinFloatParameter(10.0f, 0.0f);

/// <summary>
/// Minmal smoothness for reflection rays. If the surface has a smoothness value below this threshold, a reflection ray will not be case and it will fallback on other techniques.
Expand Down

0 comments on commit 64a4568

Please sign in to comment.