HDRP - Fix Debug View Material (#182)

* Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x
Unity-Technologies · Jan 18, 2021 · 755227a · 755227a
1 parent fc40e69
commit 755227a
Show file tree

Hide file tree

Showing 12 changed files with 22 additions and 21 deletions.
diff --git a/...ssets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlbedo.png b/...ssets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlbedo.png
diff --git a/...Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlpha.png b/...Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlpha.png
diff --git a/...Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugMetal.png b/...Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugMetal.png
diff --git a/...ssets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugNormal.png b/...ssets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugNormal.png
diff --git a/...s/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugSmoothness.png b/...s/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugSmoothness.png
diff --git a/...ssets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlbedo.png b/...ssets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlbedo.png
diff --git a/...Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlpha.png b/...Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlpha.png
diff --git a/...Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugMetal.png b/...Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugMetal.png
diff --git a/...ssets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugNormal.png b/...ssets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugNormal.png
diff --git a/...s/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugSmoothness.png b/...s/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugSmoothness.png
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed timing issues with accumulation motion blur
 - Fixed an issue with the frame count management for the volumetric fog (case 1299251).
 - Fixed an issue with material using distortion from ShaderGraph init after Material creation (case 1294026)
+- VFX : Debug material view incorrect depth test. (case 1293291)
 
 ### Changed
 - Removed the material pass probe volumes evaluation mode.

diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.Debug.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.Debug.cs
@@ -528,7 +528,7 @@ TextureHandle RenderDebugViewMaterial(RenderGraph renderGraph, CullingResults cu
                     passData.transparentRendererList = builder.UseRendererList(
                         renderGraph.CreateRendererList(CreateTransparentRendererListDesc(cull, hdCamera.camera, m_AllTransparentPassNames,
                             rendererConfiguration: m_CurrentRendererConfigurationBakedLighting,
-                            stateBlock: m_DepthStateOpaque)));
+                            stateBlock: m_DepthStateNoWrite)));
 
                     passData.clearColorTexture = Compositor.CompositionManager.GetClearTextureForStackedCamera(hdCamera);   // returns null if is not a stacked camera
                     passData.clearDepthTexture = Compositor.CompositionManager.GetClearDepthForStackedCamera(hdCamera);     // returns null if is not a stacked camera