Fix some burst warnings for player creation on latest trunk (#6263)

Unity-Technologies · Nov 10, 2021 · 937ab33 · 937ab33
1 parent abe3bca
commit 937ab33
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/com.unity.render-pipelines.high-definition/Runtime/Debug/LightingDebug.cs b/com.unity.render-pipelines.high-definition/Runtime/Debug/LightingDebug.cs
@@ -1,4 +1,5 @@
 using System;
+using Unity.Burst.CompilerServices;
 
 namespace UnityEngine.Rendering.HighDefinition
 {
@@ -105,6 +106,10 @@ public enum DebugLightLayersMask
 
     static class DebugLightHierarchyExtensions
     {
+
+#if DEBUG
+       [IgnoreWarning(1370)] //Ignore throwing exception warning on burst..
+#endif
         public static bool IsEnabledFor(
             this DebugLightFilterMode mode,
             GPULightType gpuLightType,

diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDGpuLightsBuilder.Jobs.cs b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDGpuLightsBuilder.Jobs.cs
@@ -3,6 +3,7 @@
 using Unity.Jobs;
 using Unity.Collections;
 using Unity.Collections.LowLevel.Unsafe;
+using Unity.Burst.CompilerServices;
 using System.Threading;
 
 namespace UnityEngine.Rendering.HighDefinition
@@ -123,6 +124,9 @@ internal struct CreateGpuLightDataJob : IJobParallelFor
             public NativeArray<int> gpuLightCounters;
             #endregion
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             private ref HDLightRenderData GetLightData(int dataIndex)
             {
 #if DEBUG
@@ -336,6 +340,9 @@ public static void ConvertLightToGPUFormat(
                 }
             }
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             private void StoreAndConvertLightToGPUFormat(
                 int outputIndex, int lightIndex,
                 LightCategory lightCategory, GPULightType gpuLightType, LightVolumeType lightVolumeType)
@@ -386,6 +393,9 @@ private void StoreAndConvertLightToGPUFormat(
                 lights[outputIndex] = lightData;
             }
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             private void ComputeLightVolumeDataAndBound(
                 LightCategory lightCategory, GPULightType gpuLightType, LightVolumeType lightVolumeType,
                 in VisibleLight light, in LightData lightData, in Vector3 lightDimensions, in Matrix4x4 worldToView, int outputIndex)
@@ -568,6 +578,9 @@ private void ComputeLightVolumeDataAndBound(
             }
 
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             private void ConvertDirectionalLightToGPUFormat(
                 int outputIndex, int lightIndex, LightCategory lightCategory, GPULightType gpuLightType, LightVolumeType lightVolumeType)
             {

diff --git a/...-pipelines.high-definition/Runtime/Lighting/Light/HDProcessedVisibleLightsBuilder.Jobs.cs b/...-pipelines.high-definition/Runtime/Lighting/Light/HDProcessedVisibleLightsBuilder.Jobs.cs
@@ -5,6 +5,7 @@
 using Unity.Mathematics;
 using System.Threading;
 using Unity.Collections.LowLevel.Unsafe;
+using Unity.Burst.CompilerServices;
 
 namespace UnityEngine.Rendering.HighDefinition
 {
@@ -216,6 +217,9 @@ private HDProcessedVisibleLightsBuilder.ShadowMapFlags EvaluateShadowState(
                 return flags;
             }
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             private ref HDLightRenderData GetLightData(int dataIndex)
             {
 #if DEBUG
@@ -229,6 +233,9 @@ private ref HDLightRenderData GetLightData(int dataIndex)
                 }
             }
 
+#if DEBUG
+            [IgnoreWarning(1370)] //Ignore throwing exception warning.
+#endif
             public void Execute(int index)
             {
                 VisibleLight visibleLight = visibleLights[index];