Removed the upper clamp values for recursive rendering and light clus…

…ter size (case 1294620) #2753
Unity-Technologies · Jan 23, 2021 · d54ee50 · d54ee50
1 parent 9f0e755
commit d54ee50
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -103,6 +103,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Transparent materials created by the Model Importer are set to not cast shadows. ( case 1295747)
 - Change some light unit slider value ranges to better reflect the lighting scenario.
 - Change the tooltip for color shadows and semi-transparent shadows (case 1307704).
+- Removed the superior clamping value for the ray tracing light cluster size.
 
 ## [10.2.1] - 2020-11-30
 

diff --git a/...er-pipelines.high-definition/Editor/RenderPipeline/Raytracing/RecursiveRenderingEditor.cs b/...er-pipelines.high-definition/Editor/RenderPipeline/Raytracing/RecursiveRenderingEditor.cs
@@ -1,7 +1,7 @@
+using UnityEngine;
 using UnityEditor.Rendering;
 using UnityEditor.Rendering.HighDefinition;
 using UnityEngine.Rendering.HighDefinition;
-using UnityEngine.Rendering;
 
 namespace UnityEditor.Experimental.Rendering.HighDefinition
 {
@@ -26,6 +26,8 @@ public override void OnEnable()
             m_MinSmoothness = Unpack(o.Find(x => x.minSmoothness));
         }
 
+        static public readonly GUIContent k_RayLengthText = EditorGUIUtility.TrTextContent("Max Ray Length", "This defines the maximal travel distance of rays.");
+
         public override void OnInspectorGUI()
         {
             HDRenderPipelineAsset currentAsset = HDRenderPipeline.currentAsset;
@@ -47,7 +49,7 @@ public override void OnInspectorGUI()
                     {
                         PropertyField(m_LayerMask);
                         PropertyField(m_MaxDepth);
-                        PropertyField(m_RayLength);
+                        PropertyField(m_RayLength, k_RayLengthText);
                         PropertyField(m_MinSmoothness);
                     }
                 }

diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/LightCluster.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/LightCluster.cs
@@ -13,7 +13,7 @@ public sealed class LightCluster : VolumeComponent
         /// Controls the range of the cluster around the camera.
         /// </summary>
         [Tooltip("Controls the range of the cluster around the camera.")]
-        public ClampedFloatParameter cameraClusterRange = new ClampedFloatParameter(10f, 0.001f, 50f);
+        public MinFloatParameter cameraClusterRange = new MinFloatParameter(10.0f, 0.001f);
         /// <summary>
         /// Default constructor for the light cluster volume component.
         /// </summary>

diff --git a/....render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/RecursiveRendering.cs b/....render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/RecursiveRendering.cs
@@ -31,8 +31,7 @@ public sealed class RecursiveRendering : VolumeComponent
         /// <summary>
         /// This defines the maximal travel distance of rays.
         /// </summary>
-        [Tooltip("Ray Length. This defines the maximal travel distance of rays.")]
-        public ClampedFloatParameter rayLength = new ClampedFloatParameter(10f, 0f, 50f);
+        public MinFloatParameter rayLength = new MinFloatParameter(10.0f, 0.0f);
 
         /// <summary>
         /// Minmal smoothness for reflection rays. If the surface has a smoothness value below this threshold, a reflection ray will not be case and it will fallback on other techniques.