[10.x.x] Bugfix 1262887 - Transparent meshes are rendered as opaques when using Custom Render Pass #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi-lira
suggested changes
Aug 14, 2020
...ersalGraphicsTest/Assets/Scenes/110_URPShadersAlphaOutputCustomFeature/RenderTransparents.cs
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Shaders/BakedLitInput.hlsl
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.universal/Shaders/BakedLitInput.hlsl
Outdated
Show resolved
Hide resolved
…de file [Skip CI]
…erered-opaque # Conflicts: # com.unity.render-pipelines.universal/Shaders/LitInput.hlsl # com.unity.render-pipelines.universal/Shaders/Particles/ParticlesLitInput.hlsl
phi-lira
approved these changes
Aug 21, 2020
com.unity.render-pipelines.universal/Runtime/Passes/DrawObjectsPass.cs
Outdated
Show resolved
Hide resolved
… might potentially use it
…erered-opaque # Conflicts: # com.unity.render-pipelines.universal/Shaders/LitInput.hlsl
…erered-opaque # Conflicts: # com.unity.render-pipelines.universal/Shaders/LitInput.hlsl # com.unity.render-pipelines.universal/Shaders/Particles/ParticlesLitInput.hlsl
erikabar
requested review from
erikabar and
fra-frassineti-unity
and removed request for
a team and
erikabar
fra-frassineti-unity
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Version: 2020.2.0b1.2959
Revision: trunk 4ae7c5e87f33
Built: Tue, 25 Aug 2020 03:44:09 GMT
Test Doc: https://docs.google.com/document/d/14NkqK0MymB0gfKdafHcTIedQoDFFfDK3gLGUK22sIEs/edit?usp=sharing
ellioman
deleted the
universal/bugfix/1262887-transparents-renderered-opaque
branch
ellioman
added a commit
that referenced
this pull request
Sep 25, 2020
ellioman
added a commit
that referenced
this pull request
Sep 29, 2020
ellioman
added
backported-7.x
backported-8.x
and removed
needs-backport-7.x
needs-backport-8.x
testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes bug 1262887.
In January I originally made a PR to fix bug 1168283.
The new bug shows that my previous solution didn't work in all cases. An example is if the renderer renders opaque objects with DrawObjectsPass and then transparent objects with a custom renderer feature, the transparent objects would be rendered as opaque as well.
This PR fixes the issue by:
_DrawObjectPassDatain our shaders_Surfaceto our CBuffers, which is either 0 (Opaque) or 1 (Transparent)Automated Tests
Added a new test scene 110_URPShadersAlphaOutputCustomFeature, which is almost exactly the test scene I added when fixing the previous bug except it now uses a custom pass to render the transparent objects.
Results before this PR:
Results with this PR:
Yamato**
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Fbugfix%252F1262887-transparents-renderered-opaque