Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x.x] Update URP test 035 and 130 reference images for Android Vulkan #1732

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

tomzig16
Copy link
Contributor

@tomzig16 tomzig16 commented Sep 1, 2020

Purpose of this PR

Last week there were few changes to the reference images but as Vulkan was not working properly fix for it was delayed. This PR updates reference images for those two tests for Android Vulkan platform


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
Yamato test run on Vulkan

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/android%252Furp%252Fvulkan%252Fupdate-broken-tests

Any test projects to go with this to help reviewers?
No changes were made to the projects


Comments to reviewers

None

@tomzig16 tomzig16 marked this pull request as ready for review September 1, 2020 16:03
@ellioman ellioman merged commit e180ad1 into master Sep 2, 2020
@ellioman ellioman deleted the android/urp/vulkan/update-broken-tests branch September 2, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants