Avoid errors if user define null params in volume component #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
changed the title
|
It appears that you made a non-draft PR! |
… mode (render graph). (#2323)
* Add frame setting * changelog * Grey setting out and make it always available. * Reverts tuff meant for antoher branch Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Rename function * Undoable "enable compositor" * Undo/Redo Enable/Disable compositor Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Improved the punctual shadow algorithm (it's less agressive now) * Updated changelog
JulienIgnace-Unity
approved these changes
Oct 23, 2020
* Remove perChannelMask * changelog
* Fixed a nullref when a diffusion profile was created * Updated changelog * Trying to fix diffusion profile asset dependency * Fixed export as package * Updated changelog Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Renaming * Changelog * Fix typos
… into hd/bugfix # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
This reverts commit 58152f0. # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
* - Now the DXR wizard displays the name of the target asset that needs to be changed. - The DXR wizard displays asset changes as warnings and default frame settings as infos. - Added the status check of default camera frame settings in the DXR wizard. * review corrections Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Expose shader pass names API * Updated changelog * exposed per object data in HDUtils * changed constants to accessors * Moved getters to static Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
…dows. (#2339) * - Updated the documentation about shadow matte and SSShadow and RTShadows. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Use SafeNormalize * Update CHANGELOG.md Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Make sure we clamp correctly when sampling in TAA * Changelog * More safe fix. Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
…olution and then reverted back (#2322) * Reset every now and then * Changelog * Bump min to 1440 * Update CHANGELOG.md Fixed changelog * Avoid reset if we still need the high res Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Renaming * Changelog * Fix typos * Update HDWizard.Window.cs typo * Update HDWizard.Window.cs typo 2 Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>
…5268). (#2330) * Added default volume profile asset change to the undo stack. * Updated changelog. * ... * ... Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
|
The fix itself is fine but I see a lot of other unrelated fixes in this PR. Did a merge go wrong or...? |
|
@Chman PR updated, can you review, thanks |
Chman
approved these changes
Oct 26, 2020
sebastienlagarde
deleted the
HDRP/avoid-errors-if-user-define-null-params-in-volumes
branch
sebastienlagarde
added a commit
that referenced
this pull request
Oct 26, 2020
* Null guard and warning * Changelog * Fixing exceptions in the console when putting the SSGI in low quality mode (render graph). (#2323) * Add VT frame settings (#2286) * Add frame setting * changelog * Grey setting out and make it always available. * Reverts tuff meant for antoher branch Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix undo/redo compositor (#2300) * Rename function * Undoable "enable compositor" * Undo/Redo Enable/Disable compositor Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Restored purge of unused resources in render graph (#2306) * Improve punctual shadow resolution rescale algorithm (#2309) * Improved the punctual shadow algorithm (it's less agressive now) * Updated changelog * Remove unused references of the HDRP asset in decal code (#2326) * Remove perChannelMask * changelog * Fix diffusion profile dependency (#2327) * Fixed a nullref when a diffusion profile was created * Updated changelog * Trying to fix diffusion profile asset dependency * Fixed export as package * Updated changelog Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Standardize naming for Transparent receive SSR (#2329) * Renaming * Changelog * Fix typos * Revert "Standardize naming for Transparent receive SSR (#2329)" This reverts commit 58152f0. # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Improvements to the DXR Wizard (#2295) * - Now the DXR wizard displays the name of the target asset that needs to be changed. - The DXR wizard displays asset changes as warnings and default frame settings as infos. - Added the status check of default camera frame settings in the DXR wizard. * review corrections Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Expose HDRP shader tag IDs and per object config (#2292) * Expose shader pass names API * Updated changelog * exposed per object data in HDUtils * changed constants to accessors * Moved getters to static Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * - Updated the documentation about shadow matte and SSShadow and RTShadows. (#2339) * - Updated the documentation about shadow matte and SSShadow and RTShadows. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed warnings when new input system is enabled (#2274) * Fix nan when decal affect normals (#2319) * Use SafeNormalize * Update CHANGELOG.md Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix bleeding of a view into another caused by TAA (#2317) * Make sure we clamp correctly when sampling in TAA * Changelog * More safe fix. Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Reset RT Handle size every now and then in editor if set to a big resolution and then reverted back (#2322) * Reset every now and then * Changelog * Bump min to 1440 * Update CHANGELOG.md Fixed changelog * Avoid reset if we still need the high res Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Hdrp/standardize transparent receive ssr (#2338) * Renaming * Changelog * Fix typos * Update HDWizard.Window.cs typo * Update HDWizard.Window.cs typo 2 Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Added default volume profile asset change to the undo stack (case 1285268). (#2330) * Added default volume profile asset change to the undo stack. * Updated changelog. * ... * ... Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Restored default directional light intensity constant (#2345) * Fixed changelog * More changelog fix * Remove useless menu entry (#2335) * Fixed the ray tracing shadow UI being displayed while it shouldn't (case 1286391). (#2341) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add fade distance for light impact on volumetrics (#2291) * Fade * changelog * Don't display on directional Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bit in FrameSettings * Update sample cubemap image * Revert "Update sample cubemap image" This reverts commit 32ba2a8. * revert: Improve punctual shadow resolution rescale algorithm (#2309) * Update TestCaseFilters.asset * Merge branch 'master' into hd/bugfix * Update SG_DS_Flipped.mat * update settings * Update CHANGELOG.md * remove test case filter in runtime test * migrate correctly to enable virtual texturing. * revert some change one in Hdrp/standardize transparent receive ssr #2338 * Fix breaking change in CoreEditorUtils.cs * Revert "remove test case filter in runtime test" This reverts commit ce8389b. * Revert "Restored purge of unused resources in render graph (#2306)" This reverts commit bc54701. * Update documentation * Revert: Fix nan when decal affect normals (#2319) * Update CoreEditorUtils.cs Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1279917/
The pattern that is mentioned in the bug is a bug in itself, but indeed we don't do much to help the user finding it and we instead just block everything and spam errors.
This change add some guards to avoid the error and adds a warning to point out which volume component has a faulty parameter (Cannot really print parameter name though sadly).
What did I test: the repro project :)