Fix Volume Component Quality Setting Override States #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty state when copying parameter presets
sebastienlagarde
approved these changes
Oct 26, 2020
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Override state of quality parameters should inheret the overall quality state when copying parameter presets * Revert DoF's manual disable of quality parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Small PR that fixes an issue with the default and general behavior of quality setting properties.
Before, quality settings would by default be forced enabled, and not honor the state of the quality preset mode:
After, quality settings will inherit the override state of the quality preset mode:
Testing status
Locally tested on all volume components the intended new behavior.
Comments to reviewers
~