Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x.x] Fixed postFX vertex shader backward compatibility #2462

Merged
merged 2 commits into from
Oct 30, 2020
Merged

[11.x.x] Fixed postFX vertex shader backward compatibility #2462

merged 2 commits into from
Oct 30, 2020

Conversation

thomas-zeng
Copy link
Contributor

@thomas-zeng thomas-zeng commented Oct 29, 2020 •
edited
Loading

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

  • Added back Vert to be compatible with old postFX shaders

Testing status

  • Manually tested template scene

Comments to reviewers

  • We should verify this PR fixed the broken assetstore asset from URP8

@thomas-zeng thomas-zeng requested a review from a team as a code owner October 29, 2020 17:58
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@phi-lira phi-lira changed the title [10.x.x] Fixed postFX vertex shader backward compatibility [11.x.x] Fixed postFX vertex shader backward compatibility Oct 30, 2020
@cinight cinight self-requested a review October 30, 2020 10:07
cinight
cinight approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@cinight cinight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified bug fix. All good now.

@phi-lira
Copy link
Contributor

Yamato issues related to the MinAABB (fixed in master) and OSX connetivity bokken issue.

@phi-lira phi-lira merged commit 33e0650 into master Oct 30, 2020
@phi-lira phi-lira deleted the universal/xr/add-postfx-backcompat-vert branch October 30, 2020 10:14
sebastienlagarde added a commit that referenced this pull request Oct 30, 2020
@sebastienlagarde
Revert "[11.x.x] Fixed postFX vertex shader backward compatibility (#…
8901433 
…2462)"

This reverts commit 33e0650.
thomas-zeng added a commit that referenced this pull request Nov 2, 2020
@thomas-zeng
[11.x.x] Fixed postFX vertex shader backward compatibility (#2462)
4eced2a 
* Added Vert back to remain backward compatible with the asset store assets.

* Move the code around.
@thomas-zeng thomas-zeng mentioned this pull request Nov 2, 2020
Merged
4 tasks
phi-lira pushed a commit that referenced this pull request Nov 3, 2020
@thomas-zeng
[11.x.x] Fixed postFX vertex shader backward compatibility (#2462) (#…
3d8e39e 
…2501)

* Added Vert back to remain backward compatible with the asset store assets.

* Move the code around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phi-lira phi-lira phi-lira approved these changes

@cinight cinight cinight approved these changes

Assignees
No one assigned
Labels
backported-10.x universal XR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas-zeng @phi-lira @cinight