Fix HDRP Case 1288747 #2465
Merged
Fix HDRP Case 1288747 #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Oct 30, 2020
sebastienlagarde
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit f27103b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Small UI fix for https://fogbugz.unity3d.com/f/cases/1288747/
The Rough Reflections field was drawn twice for Planar Reflection editor, now it will correctly draw once.
Before:
After:
Testing status
Locally, toggled and double checked planar reflection behavior with the property.
Comments to reviewers
I tried to do this fix against
HDRP/bugfix, but it appears the issue was not present in this branch. So I will do it against master.